From 5768f81fc2b0ddbe6bba4536b11a3f3032388bf6 Mon Sep 17 00:00:00 2001 From: Timo Sirainen Date: Mon, 22 Dec 2025 22:25:04 +0200 Subject: [PATCH] [PATCH] managesieve-login: Fix crash when command didn't finish on the first call Gbp-Pq: Name CVE-2025-59032.patch --- pigeonhole/src/managesieve-login/client.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/pigeonhole/src/managesieve-login/client.c b/pigeonhole/src/managesieve-login/client.c index cc0aa46..c0711cd 100644 --- a/pigeonhole/src/managesieve-login/client.c +++ b/pigeonhole/src/managesieve-login/client.c @@ -336,10 +336,12 @@ static bool managesieve_client_input_next_cmd(struct client *client) if (args[0].type != MANAGESIEVE_ARG_EOL) ret = -1; } - } - if (ret > 0) { + if (ret > 0) + ret = msieve_client->cmd->func(msieve_client, args); + } else { + /* Continue unfinished command */ i_assert(msieve_client->cmd != NULL); - ret = msieve_client->cmd->func(msieve_client, args); + ret = msieve_client->cmd->func(msieve_client, NULL); } if (ret != 0) -- 2.30.2